bgpd: fix misplaced arguments in bgp_redistribute_add() #16874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the misplaced arguments "bhtype" and "api.distance" in bgp_redistribute_add(). Signed-off-by: Enke Chen <[email protected]>
In ospf_multi_vrf_bgp_route_leak, the admin distance for the redistributed ospf route should be 110, and should remain as 110 after it's imported into another vrf, and then downloaded to zebra. Signed-off-by: Enke Chen <[email protected]>
|
@ton31337 thoughts on needing a topotest? |
|
I guess we already had an implied topotest that was just wrong. |
ton31337
approved these changes
Sep 19, 2024
|
I'm gonna go ahead and merge this as that it's unlikely to accidently change in the future and changing something would break tests, so we would catch it. |
|
Thanks @donaldsharp and @ton31337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the misplaced arguments "bhtype" and "api.distance" in bgp_redistribute_add().